[Proposal] Removed Model::getConnectionName() override #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a great package, but it overrides
Model::getConnectionName()
, which proves to be a problem. We already have simple traits that do something similar and we can't have both.This solution moves the fallback call to
config()
(which one could argue might not be necessary) to the two instances wheregetConnectionName()
is called.Alternatives:
getConnectionName()
togetLaravelModelSettingsConnectionName()
, which, in turn, callsgetConnectionName()
and handles the fallback.Model
will eventually fall back to the default connection. (SeeIlluminate\Database\ConnectionResolver
.)Let me know if you have questions/concerns, and thanks for the great work thus far. 🤓